Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update connector drivers #18400

Merged
merged 5 commits into from
Jul 25, 2023
Merged

Update connector drivers #18400

merged 5 commits into from
Jul 25, 2023

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Jul 25, 2023 •
edited
Loading

Updates drivers for:

  • MySQL
  • MongoDB
  • Redshift
  • Singlestore
  • MSSQL

Internal change. No release notes needed.

@cla-bot cla-bot bot added the cla-signed label Jul 25, 2023
@wendigo wendigo requested a review from hashhar July 25, 2023 08:40
@github-actions github-actions bot added tests:hive mongodb MongoDB connector labels Jul 25, 2023
@wendigo wendigo force-pushed the serafin/update-drivers branch from a2cba97 to a99da56 Compare July 25, 2023 10:38
hashhar
hashhar reviewed Jul 25, 2023
View reviewed changes
pom.xml Show resolved Hide resolved
hashhar
hashhar reviewed Jul 25, 2023
View reviewed changes
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % comments

@wendigo wendigo requested a review from hashhar July 25, 2023 12:51
hashhar
hashhar approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wendigo
Copy link
Contributor Author

wendigo commented Jul 25, 2023 

2023-07-25T11:24:34.8685891Z [ERROR] Tests run: 1581, Failures: 1, Errors: 0, Skipped: 31, Time elapsed: 1,717.762 s <<< FAILURE! - in TestSuite
2023-07-25T11:24:34.8687072Z [ERROR] io.trino.plugin.iceberg.TestIcebergMinioOrcConnectorTest.testOptimizeTableAfterDeleteWithFormatVersion2  Time elapsed: 0.985 s  <<< FAILURE!
2023-07-25T11:24:34.8687852Z java.lang.AssertionError: 
2023-07-25T11:24:34.8688283Z 
2023-07-25T11:24:34.8688568Z Expected size: 1 but was: 2 in:
2023-07-25T11:24:34.8689543Z ["s3://test-iceberg-orc-13rbja3ybl/iceberg_data/tpch/test_optimize_pi4c2ru9tp-a865d1104ae34733ae8c0aeb6bad4ebb/data/20230725_111220_05377_agmni-6678f086-b6e9-49d5-b8d1-ec7ce0b3b1c5.orc",
2023-07-25T11:24:34.8690607Z     "s3://test-iceberg-orc-13rbja3ybl/iceberg_data/tpch/test_optimize_pi4c2ru9tp-a865d1104ae34733ae8c0aeb6bad4ebb/data/20230725_111220_05377_agmni-8d315e4c-d105-426d-b785-513822e4f0ea.orc"]
2023-07-25T11:24:34.8691529Z 	at io.trino.plugin.iceberg.BaseIcebergConnectorTest.testOptimizeTableAfterDeleteWithFormatVersion2(BaseIcebergConnectorTest.java:5148)
2023-07-25T11:24:34.8692291Z 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
2023-07-25T11:24:34.8692908Z 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
2023-07-25T11:24:34.8693515Z 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
2023-07-25T11:24:34.8694006Z 	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
2023-07-25T11:24:34.8694480Z 	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:104)
2023-07-25T11:24:34.8694953Z 	at org.testng.internal.Invoker.invokeMethod(Invoker.java:645)
2023-07-25T11:24:34.8695359Z 	at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:851)
2023-07-25T11:24:34.8695774Z 	at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1177)
2023-07-25T11:24:34.8696246Z 	at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:129)
2023-07-25T11:24:34.8696722Z 	at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:112)
2023-07-25T11:24:34.8697208Z 	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
2023-07-25T11:24:34.8697721Z 	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
2023-07-25T11:24:34.8698120Z 	at java.base/java.lang.Thread.run(Thread.java:833)

@wendigo wendigo merged commit c43020a into trinodb:master Jul 25, 2023
@wendigo wendigo deleted the serafin/update-drivers branch July 25, 2023 13:09
@github-actions github-actions bot added this to the 423 milestone Jul 25, 2023
@hashhar
Copy link
Member

hashhar commented Jul 26, 2023

@findinpath Is that failing optimize test known to be flaky? Can we fix it?

@ebyhr
Copy link
Member

ebyhr commented Jul 26, 2023

The test was fixed about 30 minutes ago. #18415

@colebow colebow mentioned this pull request Aug 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebyhr ebyhr ebyhr left review comments

@hashhar hashhar hashhar approved these changes

Assignees
No one assigned
Labels
cla-signed mongodb MongoDB connector
Milestone
423
Development

Successfully merging this pull request may close these issues.
3 participants
@wendigo @hashhar @ebyhr